linux-kernel - Re: [PATCH] V4l: omap4iss: Clean up file handle in open() and release().

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2371533.nuiRhppDdV@avalon>
Date:   Thu, 01 Dec 2016 12:29:23 +0200
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Shailendra Verma <shailendra.v@...sung.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-media@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org,
        Shailendra Verma <shailendra.capricorn@...il.com>,
        vidushi.koul@...sung.com
Subject: Re: [PATCH] V4l: omap4iss: Clean up file handle in open() and release().

Hi Shailendra,

Thank you for the patch.

On Thursday 01 Dec 2016 10:22:52 Shailendra Verma wrote:
> Both functions initialize the file handle with v4l2_fh_init()
> and thus need to call clean up with v4l2_fh_exit() as appropriate.
> 
> Signed-off-by: Shailendra Verma <shailendra.v@...sung.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

and applied to my tree for v4.11.

> ---
>  drivers/staging/media/omap4iss/iss_video.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/media/omap4iss/iss_video.c
> b/drivers/staging/media/omap4iss/iss_video.c index c16927a..077c9f8 100644
> --- a/drivers/staging/media/omap4iss/iss_video.c
> +++ b/drivers/staging/media/omap4iss/iss_video.c
> @@ -1141,6 +1141,7 @@ static int iss_video_open(struct file *file)
>  done:
>  	if (ret < 0) {
>  		v4l2_fh_del(&handle->vfh);
> +		v4l2_fh_exit(&handle->vfh);
>  		kfree(handle);
>  	}
> 
> @@ -1162,6 +1163,7 @@ static int iss_video_release(struct file *file)
>  	vb2_queue_release(&handle->queue);
> 
>  	v4l2_fh_del(vfh);
> +	v4l2_fh_exit(vfh);
>  	kfree(handle);
>  	file->private_data = NULL;

-- 
Regards,

Laurent Pinchart