linux-kernel - Re: [PATCH] Platform: vsp1: Clean up file handle in open() error path.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2714292.XDaUmZ9RCx@avalon>
Date:   Thu, 01 Dec 2016 12:30:07 +0200
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Shailendra Verma <shailendra.v@...sung.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-renesas-soc@...r.kernel.org,
        Shailendra Verma <shailendra.capricorn@...il.com>,
        vidushi.koul@...sung.com
Subject: Re: [PATCH] Platform: vsp1: Clean up file handle in open() error path.

Hi Shailendra,

Thank you for the patch.

On Thursday 01 Dec 2016 10:20:18 Shailendra Verma wrote:
> v4l2_fh_init is already done.So call the v4l2_fh_exit in error condition
> before returing from the function.
> 
> Signed-off-by: Shailendra Verma <shailendra.v@...sung.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

and applied to my tree for v4.11.

> ---
>  drivers/media/platform/vsp1/vsp1_video.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/vsp1/vsp1_video.c
> b/drivers/media/platform/vsp1/vsp1_video.c index d351b9c..cc58163 100644
> --- a/drivers/media/platform/vsp1/vsp1_video.c
> +++ b/drivers/media/platform/vsp1/vsp1_video.c
> @@ -1044,6 +1044,7 @@ static int vsp1_video_open(struct file *file)
>  	ret = vsp1_device_get(video->vsp1);
>  	if (ret < 0) {
>  		v4l2_fh_del(vfh);
> +		v4l2_fh_exit(vfh);
>  		kfree(vfh);
>  	}

-- 
Regards,

Laurent Pinchart