linux-kernel - Re: [PATCH v2 2/3] ARM: dts: sunxi: add support for Orange Pi Zero board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <efb30303-b9bb-7a7c-4478-af485991dd86@redhat.com>
Date:   Fri, 2 Dec 2016 15:30:26 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Icenowy Zheng <icenowy@...c.xyz>,
        Maxime Ripard <maxime.ripard@...e-electrons.com>,
        André Przywara <andre.przywara@....com>
Cc:     Jonathan Corbet <corbet@....net>, Chen-Yu Tsai <wens@...e.org>,
        Mark Rutland <mark.rutland@....com>,
        Russell King <linux@...linux.org.uk>,
        Vishnu Patekar <vishnupatekar0510@...il.com>,
        Arnd Bergmann <arnd@...db.de>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v2 2/3] ARM: dts: sunxi: add support for Orange Pi Zero
 board

Hi,

On 02-12-16 15:22, Icenowy Zheng wrote:
>
>
> 01.12.2016, 17:36, "Maxime Ripard" <maxime.ripard@...e-electrons.com>:
>> On Mon, Nov 28, 2016 at 12:29:07AM +0000, André Przywara wrote:
>>>  > Something more interesting happened.
>>>  >
>>>  > Xunlong made a add-on board for Orange Pi Zero, which exposes the
>>>  > two USB Controllers exported at expansion bus as USB Type-A
>>>  > connectors.
>>>  >
>>>  > Also it exposes a analog A/V jack and a microphone.
>>>  >
>>>  > Should I enable {e,o}hci{2.3} in the device tree?
>>>
>>>  Actually we should do this regardless of this extension board. The USB
>>>  pins are not multiplexed and are exposed on user accessible pins (just
>>>  not soldered, but that's a detail), so I think they qualify for DT
>>>  enablement. And even if a user can't use them, it doesn't hurt to have
>>>  them (since they are not multiplexed).
>>
>> My main concern about this is that we'll leave regulators enabled by
>> default, for a minority of users. And that minority will prevent to do
>> a proper power management when the times come since we'll have to keep
>> that behaviour forever.
>
> I think these users can add a 'fdt set /xxx/xxx status "disabled" ' .

I don't think that will be necessary I'm pretty sure these extra usb
ports do not have a regulator for the Vbus, they just hook directly
to the 5V rail, can someone with a schematic check ?

Regards,

Hans