linux-kernel - Re: [PATCH] net: phy: dp83848: Support ethernet pause frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <80ee8058-7d6b-ea88-7ec6-20daf50a1fce@ti.com>
Date:   Fri, 2 Dec 2016 08:35:23 -0600
From:   "Andrew F. Davis" <afd@...com>
To:     Jesper Nilsson <jesper.nilsson@...s.com>,
        Florian Fainelli <f.fainelli@...il.com>
CC:     Roger Quadros <rogerq@...com>,
        "David S. Miller" <davem@...emloft.net>,
        Dan Murphy <dmurphy@...com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: phy: dp83848: Support ethernet pause frames

On 12/02/2016 08:22 AM, Jesper Nilsson wrote:
> According to the documentation, the PHYs supported by this driver
> can also support pause frames. Announce this to be so.
> Tested with a TI83822I.
> 

Looks like all PHYs supported by this driver do, so:

Acked-by: Andrew F. Davis <afd@...com>

> Signed-off-by: Jesper Nilsson <jesper.nilsson@...s.com>
> ---
>  drivers/net/phy/dp83848.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/phy/dp83848.c b/drivers/net/phy/dp83848.c
> index 800b39f..6e4117f 100644
> --- a/drivers/net/phy/dp83848.c
> +++ b/drivers/net/phy/dp83848.c
> @@ -88,7 +88,8 @@ MODULE_DEVICE_TABLE(mdio, dp83848_tbl);
>  		.phy_id		= _id,				\
>  		.phy_id_mask	= 0xfffffff0,			\
>  		.name		= _name,			\
> -		.features	= PHY_BASIC_FEATURES,		\
> +		.features	= (PHY_BASIC_FEATURES |		\
> +			SUPPORTED_Pause | SUPPORTED_Asym_Pause),\

Aligning these may look nicer though.

>  		.flags		= PHY_HAS_INTERRUPT,		\
>  								\
>  		.soft_reset	= genphy_soft_reset,		\
>