linux-kernel - Re: [PATCH] regulator: Fix regulator_get_error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKXjFTO9xQbztv9FtAN+DOUJ=az-EAyGY6-jufE-nfbkQbo7yQ@mail.gmail.com>
Date:   Mon, 5 Dec 2016 12:23:27 +0100
From:   Axel Haslam <ahaslam@...libre.com>
To:     David Lechner <david@...hnology.com>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: Fix regulator_get_error_flags() signature mismatch

On Sun, Dec 4, 2016 at 11:52 PM, David Lechner <david@...hnology.com> wrote:
> The function signature of does not match regulator_get_error_flags()
> when CONFIG_REGULATOR is not defined vs. when it is not defined.
> This makes both declarations match to prevent compiler errors.
>
> Signed-off-by: David Lechner <david@...hnology.com>
> ---
>  include/linux/regulator/consumer.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/regulator/consumer.h b/include/linux/regulator/consumer.h
> index 528eb1f..ea0fffa 100644
> --- a/include/linux/regulator/consumer.h
> +++ b/include/linux/regulator/consumer.h
> @@ -498,7 +498,8 @@ static inline unsigned int regulator_get_mode(struct regulator *regulator)
>         return REGULATOR_MODE_NORMAL;
>  }
>
> -static inline int regulator_get_error_flags(struct regulator *regulator)
> +static inline int regulator_get_error_flags(struct regulator *regulator,
> +                                           unsigned int *flags)
>  {
>         return -EINVAL;

ouch, i missed this change when i modified the patch,
sorry, and thanks for fixing it David,

Regards,
-Axel.

>  }
> --
> 2.7.4
>