linux-kernel - Re: [PATCH] scsi: hisi_sas: fix free'ing in probe and remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1fum2vy5w.fsf@sermon.lab.mkp.net>
Date:   Mon, 05 Dec 2016 16:55:23 -0500
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     John Garry <john.garry@...wei.com>
Cc:     <martin.petersen@...cle.com>, <jejb@...ux.vnet.ibm.com>,
        <john.garry2@...l.dcu.ie>, <lambert.quentin@...il.com>,
        <xuwei5@...ilicon.com>, <linux-kernel@...r.kernel.org>,
        <linux-scsi@...r.kernel.org>, <zhangfei.gao@...aro.org>,
        <linuxarm@...wei.com>, Xiaofei Tan <tanxiaofei@...wei.com>
Subject: Re: [PATCH] scsi: hisi_sas: fix free'ing in probe and remove

>>>>> "John" == John Garry <john.garry@...wei.com> writes:

John> This patch addresses 4 problems in the module probe/remove:
John> - When hisi_sas_shost_alloc() fails after we alloc shost memory,
John> we should free shost memory before the function returns.
John> - When hisi_sas_probe() fails after we alloc the HBA memories,
John> we should also free the HBA memories.
John> - We should free shost memory at the end of hisi_sas_remove().
John> - sha->core.shost is set twice, so remove extra set.

Applied to 4.10/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering