linux-kernel - Re: [PATCH v2] v4l: async: make v4l2 coexist with devicetree nodes in a dt overlay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Dec 2016 09:08:51 +0000
From:   Javi Merino <javi.merino@...nel.org>
To:     Javier Martinez Canillas <javier@....samsung.com>
Cc:     Sakari Ailus <sakari.ailus@...ux.intel.com>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: Re: [PATCH v2] v4l: async: make v4l2 coexist with devicetree nodes
 in a dt overlay

On Mon, Dec 05, 2016 at 10:13:38AM -0300, Javier Martinez Canillas wrote:
> Hello Javi,
> 
> On 12/05/2016 07:09 AM, Javi Merino wrote:
> > In asds configured with V4L2_ASYNC_MATCH_OF, the v4l2 subdev can be
> > part of a devicetree overlay, for example:
> > 
> > &media_bridge {
> > 	...
> > 	my_port: port@0 {
> > 		#address-cells = <1>;
> > 		#size-cells = <0>;
> > 		reg = <0>;
> > 		ep: endpoint@0 {
> > 			remote-endpoint = <&camera0>;
> > 		};
> > 	};
> > };
> > 
> > / {
> > 	fragment@0 {
> > 		target = <&i2c0>;
> > 		__overlay__ {
> > 			my_cam {
> > 				compatible = "foo,bar";
> > 				port {
> > 					camera0: endpoint {
> > 						remote-endpoint = <&my_port>;
> > 						...
> > 					};
> > 				};
> > 			};
> > 		};
> > 	};
> > };
> > 
> > Each time the overlay is applied, its of_node pointer will be
> > different.  We are not interested in matching the pointer, what we
> > want to match is that the path is the one we are expecting.  Change to
> > use of_node_cmp() so that we continue matching after the overlay has
> > been removed and reapplied.
> > 
> > Cc: Mauro Carvalho Chehab <mchehab@...nel.org>
> > Cc: Javier Martinez Canillas <javier@....samsung.com>
> > Cc: Sakari Ailus <sakari.ailus@...ux.intel.com>
> > Signed-off-by: Javi Merino <javi.merino@...nel.org>
> > ---
> 
> I already reviewed v1 but you didn't carry the tag. So again:

I forgot to add it :(

> Reviewed-by: Javier Martinez Canillas <javier@....samsung.com>

Thanks!
Javi