linux-kernel - Re: [PATCH v2] v4l: async: make v4l2 coexist with devicetree nodes in a dt overlay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <2ac49275-7762-5ceb-21bd-684862379610@samsung.com>
Date:   Tue, 06 Dec 2016 12:15:17 +0100
From:   Sylwester Nawrocki <s.nawrocki@...sung.com>
To:     Javi Merino <javi.merino@...nel.org>, linux-media@...r.kernel.org
Cc:     Javier Martinez Canillas <javier@....samsung.com>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: Re: [PATCH v2] v4l: async: make v4l2 coexist with devicetree nodes in
 a dt overlay

(resending, hopefully now it reaches the mailing lists)

On 12/05/2016 11:09 AM, Javi Merino wrote:

> Each time the overlay is applied, its of_node pointer will be
> different.  We are not interested in matching the pointer, what we
> want to match is that the path is the one we are expecting.  Change to
> use of_node_cmp() so that we continue matching after the overlay has
> been removed and reapplied.
> 
> Signed-off-by: Javi Merino <javi.merino@...nel.org>

Thanks, there is clearly a bug in current code as it assumed static
representation of DT in the kernel.

Reviewed-by: Sylwester Nawrocki <s.nawrocki@...sung.com>

> ---
>  drivers/media/v4l2-core/v4l2-async.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c
> index 5bada20..d33a17c 100644
> --- a/drivers/media/v4l2-core/v4l2-async.c
> +++ b/drivers/media/v4l2-core/v4l2-async.c
> @@ -42,7 +42,8 @@ static bool match_devname(struct v4l2_subdev *sd,
>  
>  static bool match_of(struct v4l2_subdev *sd, struct v4l2_async_subdev *asd)
>  {
> -	return sd->of_node == asd->match.of.node;
> +	return !of_node_cmp(of_node_full_name(sd->of_node),
> +			    of_node_full_name(asd->match.of.node));
>  }