linux-kernel - Re: [PATCH] ppdev: don't print a free'd string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161206105138.GA10275@kroah.com>
Date:   Tue, 6 Dec 2016 11:51:38 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Colin King <colin.king@...onical.com>
Cc:     Sudip Mukherjee <sudipm.mukherjee@...il.com>,
        Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ppdev: don't print a free'd string

On Fri, Dec 02, 2016 at 04:23:55PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> A previous fix of a memory leak now prints the string 'name'
> that was previously free'd.  Fix this by free'ing the string
> at the end of the function and adding an error exit path for
> the error conditions.
> 
> CoverityScan CID#1384523 ("Use after free")
> 
> Fixes: 2bd362d5f45c1 ("ppdev: fix memory leak")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/char/ppdev.c | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)

Sudip, any thoughts?