linux-kernel - Re: [PATCH] tags: honor COMPILED_SOURCE with apart output directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8737i12rxt.fsf@belgarion.home>
Date:   Tue, 06 Dec 2016 12:54:54 +0100
From:   Robert Jarzmik <robert.jarzmik@...e.fr>
To:     Michal Marek <mmarek@...e.com>
Cc:     linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] tags: honor COMPILED_SOURCE with apart output directory

Robert Jarzmik <robert.jarzmik@...e.fr> writes:

> When the kernel is compiled with an "O=" argument, the object files are
> not necessarily in the source tree, and more probably in another tree.
>
> In this situation, the current used check doesn't work, and
> COMPILED_SOURCE tags is broken with O= builds.
>
> This patch fixes it by looking for object files both in source tree and
> potential destination tree.
>
> Signed-off-by: Robert Jarzmik <robert.jarzmik@...e.fr>

Hi Marek, ping about this patch ?

Cheers.

--
Robert

PS: The patch content top-posted
> ---
>  scripts/tags.sh | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/tags.sh b/scripts/tags.sh
> index b3775a9604ea..c0220fa05617 100755
> --- a/scripts/tags.sh
> +++ b/scripts/tags.sh
> @@ -106,7 +106,9 @@ all_compiled_sources()
>  		case "$i" in
>  			*.[cS])
>  				j=${i/\.[cS]/\.o}
> -				if [ -e $j ]; then
> +				k=${i/"$tree"/"$O"\/}
> +				k=${k/\.[cS]/\.o}
> +				if [ -e $j -o -e "$k" ]; then
>  					echo $i
>  				fi
>  				;;