linux-kernel - Re: [PATCH v3 33/33] Reimplement IDR and IDA using the radix tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161206132538.e474083ae851c7284bb89b2a@linux-foundation.org>
Date:   Tue, 6 Dec 2016 13:25:38 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Matthew Wilcox <mawilcox@...rosoft.com>
Cc:     Matthew Wilcox <mawilcox@...uxonhyperv.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Konstantin Khlebnikov" <koct9i@...il.com>,
        Ross Zwisler <ross.zwisler@...ux.intel.com>,
        Matthew Wilcox <willy@...ux.intel.com>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
        Matthew Wilcox <willy@...radead.org>
Subject: Re: [PATCH v3 33/33] Reimplement IDR and IDA using the radix tree

On Tue, 6 Dec 2016 21:17:52 +0000 Matthew Wilcox <mawilcox@...rosoft.com> wrote:

> From: Andrew Morton [mailto:akpm@...ux-foundation.org]
> > On Mon, 28 Nov 2016 13:50:37 -0800 Matthew Wilcox
> > <mawilcox@...uxonhyperv.com> wrote:
> > >  include/linux/idr.h                     |  132 ++--
> > >  include/linux/radix-tree.h              |    5 +-
> > >  init/main.c                             |    3 +-
> > >  lib/idr.c                               | 1078 -------------------------------
> > >  lib/radix-tree.c                        |  632 ++++++++++++++++--
> > 
> > hm.  It's just a cosmetic issue, but perhaps the idr
> > wrappers-around-radix-tree code should be in a different .c file.
> 
> I can put some of them back into idr.c -- there's a couple of routines left in there still, so adding some more won't hurt.

OK.  Sometime.  Let's see how this lot pans out as-is for now?