linux-kernel - Re: [PATCHSET 00/10] perf sched timehist: Introduce --idle-hist option (v1)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8290e8a9-eadd-8bca-d25b-0b5880a18f33@gmail.com>
Date:   Tue, 6 Dec 2016 13:31:33 -0800
From:   David Ahern <dsahern@...il.com>
To:     Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
Cc:     Namhyung Kim <namhyung@...nel.org>, Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Jiri Olsa <jolsa@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Andi Kleen <andi@...stfloor.org>,
        Minchan Kim <minchan@...nel.org>
Subject: Re: [PATCHSET 00/10] perf sched timehist: Introduce --idle-hist
 option (v1)

On 12/6/16 11:44 AM, Arnaldo Carvalho de Melo wrote:
> Em Tue, Dec 06, 2016 at 12:40:00PM +0900, Namhyung Kim escreveu:
>> Hi,
>>
>> This patchset implements the idle hist feature which analyze reason of system
>> idle.  Sometimes I need to investigate what makes CPUs to go idle even though
>> I have jobs to do.  It may be due to I/O, waiting on lock or whatever.
> So, on a first round, I've applied the ones David acked, will try
> pushing to Ingo today.
> 
> David, I still haven't myself reviewed the patches, before that, do you
> have any strong objection to the other patches? Will you continue
> reviewing them?

patches 7-10 were fine. It's an interesting feature. My main concern was the changes to detecting idle_sample. If it works properly on RHEL6, RHEL7, and top of tree then it should be fine.