linux-kernel - Re: [PATCH] ASoC: Intel: Skylake: remove unused 'out

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161208101826.GZ6408@localhost>
Date:   Thu, 8 Dec 2016 15:48:27 +0530
From:   Vinod Koul <vinod.koul@...el.com>
To:     Kirtika Ruchandani <kirtika@...omium.org>
Cc:     tiwai@...e.com, arnd@...db.de, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org,
        Hardik T Shah <hardik.t.shah@...el.com>,
        Omair M Abdullah <omair.m.abdullah@...el.com>,
        Jeeja KP <jeeja.kp@...el.com>,
        "Subhransu S . Prusty" <subhransu.s.prusty@...el.com>,
        Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH] ASoC: Intel: Skylake: remove unused 'out_fmt' variable

On Thu, Dec 08, 2016 at 03:30:01PM +0530, Vinod Koul wrote:
> On Wed, Dec 07, 2016 at 10:01:42PM -0800, Kirtika Ruchandani wrote:
> > Commit 4cd9899f0d16 introduced struct skl_module_fmt* out_fmt without
> > using it. Compiling with W=1 gives the below warning, fix it.
> > 
> > sound/soc/intel/skylake/skl-topology.c: In function ‘skl_tplg_update_buffer_size’:
> > sound/soc/intel/skylake/skl-topology.c:301:34: warning: variable ‘out_fmt’ set but not used [-Wunused-but-set-variable]
> > 
> > This is a harmless warning and is only being fixed to reduce the noise
> > with W=1 in the kernel.
> 
> Heya,
> 
> Can you please tell me which tree this warning was found on? At least this
> doesn't exist upstream. The out_fmt is very well used.

Sorry I messed up, got confused mcfg->out_fmt variable :(

This looks fine:

Acked-by: Vinod Koul <vinod.koul@...el.com>

-- 
~Vinod