linux-kernel - Re: [PATCH] ASoC: Intel: Skylake: remove unused 'runtime' variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161208101925.GA6408@localhost>
Date:   Thu, 8 Dec 2016 15:49:25 +0530
From:   Vinod Koul <vinod.koul@...el.com>
To:     Kirtika Ruchandani <kirtika@...omium.org>
Cc:     tiwai@...e.com, arnd@...db.de, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, Jeeja KP <jeeja.kp@...el.com>,
        "Subhransu S . Prusty" <subhransu.s.prusty@...el.com>,
        Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH] ASoC: Intel: Skylake: remove unused 'runtime' variable

On Wed, Dec 07, 2016 at 10:26:20PM -0800, Kirtika Ruchandani wrote:
> skl_platform_open() defines and sets 'struct snd_pcm_runtime* runtime'
> but does not use it. Compiling with W=1 gives the following warning,
> fix it.
> 
> sound/soc/intel/skylake/skl-pcm.c: In function ‘skl_platform_open’:
> sound/soc/intel/skylake/skl-pcm.c:941:26: warning: variable ‘runtime’ set but not used [-Wunused-but-set-variable]
> 
> This was introduced with the initial driver commit a40e693c7f5e
> ("ASoC: Intel: Add Skylake HDA platform driver").
> This is a harmless warning and is only being fixed to reduce the noise
> with W=1 in the kernel.

Acked-by: Vinod Koul <vinod.koul@...el.com>

-- 
~Vinod