linux-kernel - Re: [PATCH 08/16] drivers/fsi: Add crc4 helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA0LjjVuHoggi+vMHMo6OFRfVxY7im5pEAYPGUefrci7NjPncg@mail.gmail.com>
Date:   Thu, 8 Dec 2016 13:43:33 -0600
From:   Christopher Bostic <christopher.lee.bostic@...il.com>
To:     Jeremy Kerr <jk@...abs.org>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>, linux@...linux.org.uk,
        sre@...nel.org, Michael Turquette <mturquette@...libre.com>,
        geert+renesas@...der.be,
        Open List OF Flattened dev tree bindings 
        <devicetree@...r.kernel.org>,
        "Moderated list: ARM PORT" <linux-arm-kernel@...ts.infradead.org>,
        Joel Stanley <joel@....id.au>,
        Linux open list <linux-kernel@...r.kernel.org>,
        Andrew Jeffery <andrew@...id.au>,
        Alistair Popple <alistair@...ple.id.au>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Chris Bostic <cbostic@...ibm.com>
Subject: Re: [PATCH 08/16] drivers/fsi: Add crc4 helpers

On Wed, Dec 7, 2016 at 5:33 PM, Jeremy Kerr <jk@...abs.org> wrote:
> Hi Greg,
>
>> Why not just create lib/crc4.c with these functions, like the other crc
>> functions in the kernel?
>
> Two (bad) reasons:
>
>  - The crc4 implementation here is pretty specific to the FSI
>    usage (only supporting 4-bit-sized chunks), to keep the math & lookup
>    table simple
>
>  - I'm lazy
>
> So yes, we should spend the effort now to make this generic enough for
> a lib/crc4.c. Would we want to support different values for the
> polynomial?
>
> Chris: do you want me to to that, or will you?

Hi Jeremy,

I'll take this one.  Will implement as per Greg's suggestions.

Thanks,
Chris

>
> Cheers,
>
>
> Jeremy