linux-kernel - Re: [PATCH 04/16] drivers/fsi: Add fsi master definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAA0LjjUOuQXW_pJ0yM=vtKKS09Y-oALUvhF9KPDzx0GF+Xkmew@mail.gmail.com>
Date:   Thu, 8 Dec 2016 16:49:06 -0600
From:   Christopher Bostic <christopher.lee.bostic@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>, linux@...linux.org.uk,
        sre@...nel.org, Michael Turquette <mturquette@...libre.com>,
        geert+renesas@...der.be,
        Open List OF Flattened dev tree bindings 
        <devicetree@...r.kernel.org>,
        "Moderated list: ARM PORT" <linux-arm-kernel@...ts.infradead.org>,
        Jeremy Kerr <jk@...abs.org>, Joel Stanley <joel@....id.au>,
        Linux open list <linux-kernel@...r.kernel.org>,
        Andrew Jeffery <andrew@...id.au>,
        Alistair Popple <alistair@...ple.id.au>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Chris Bostic <cbostic@...ibm.com>
Subject: Re: [PATCH 04/16] drivers/fsi: Add fsi master definition

On Wed, Dec 7, 2016 at 3:06 AM, Greg KH <gregkh@...uxfoundation.org> wrote:
> On Tue, Dec 06, 2016 at 08:09:30PM -0600, Chris Bostic wrote:
>> From: Jeremy Kerr <jk@...abs.org>
>>
>> Signed-off-by: Jeremy Kerr <jk@...abs.org>
>> Signed-off-by: Chris Bostic <cbostic@...ibm.com>
>> ---
>>  drivers/fsi/fsi-core.c   | 20 ++++++++++++++++++++
>>  drivers/fsi/fsi-master.h | 37 +++++++++++++++++++++++++++++++++++++
>>  2 files changed, 57 insertions(+)
>>  create mode 100644 drivers/fsi/fsi-master.h
>>
>> diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c
>> index 3d55bd5..ce9428d 100644
>> --- a/drivers/fsi/fsi-core.c
>> +++ b/drivers/fsi/fsi-core.c
>> @@ -17,6 +17,26 @@
>>  #include <linux/fsi.h>
>>  #include <linux/module.h>
>>
>> +#include "fsi-master.h"
>> +
>> +static atomic_t master_idx = ATOMIC_INIT(-1);
>
> You don't really want/need an atomic variable, please use the simple ida
> interface instead.

Greg,

Will make the change to simple ida interface.

Thanks for your feedback,
Chris

>
> thanks,
>
> greg k-h