linux-kernel - Re: [patch] x86/ldt: make a size variable unsigned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALCETrXaiSe8kYwZC1=16Rx=38F2zJKNDxeuwnAT3-POQw=RbQ@mail.gmail.com>
Date:   Thu, 8 Dec 2016 14:29:54 -0800
From:   Andy Lutomirski <luto@...capital.net>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, X86 ML <x86@...nel.org>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Andrey Ryabinin <aryabinin@...tuozzo.com>,
        Andy Lutomirski <luto@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [patch] x86/ldt: make a size variable unsigned

On Thu, Dec 8, 2016 at 2:56 AM, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> My static checker complains that we put an upper bound on the "size"
> variable but not a lower bound.  The checker is not smart enough to know
> the possible ranges of "old_mm->context.ldt->size" from
> init_new_context_ldt() so it thinks maybe it could be negative.
>
> Let's make it unsigned to silence the warning and future proof the code
> a bit.

Acked-by: Andy Lutomirski <luto@...nel.org>