lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 11 Dec 2016 13:34:06 +0530 From: arvind Yadav <arvind.yadav.cs@...il.com> To: Robert Jarzmik <robert.jarzmik@...e.fr> Cc: daniel@...que.org, haojian.zhuang@...il.com, linus.walleij@...aro.org, linux-arm-kernel@...ts.infradead.org, linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions Yes, It will not fixes any defect. But we are going to free allocate memory then why we need devm api. In this case Devm will first add this entry to list and immediately it will remove from list. -Arvind On Saturday 10 December 2016 02:49 PM, Robert Jarzmik wrote: > Arvind Yadav <arvind.yadav.cs@...il.com> writes: > > Hi Arvind, > >> In functions pxa2xx_build_functions, the memory allocated for >> 'functions' is live within the function only. After the >> allocation it is immediately freed with devm_kfree. There is >> no need to allocate memory for 'functions' with devm function >> so replace devm_kcalloc with kcalloc and devm_kfree with kfree. > That's not very true : the "need" is to spare the "manual" kfree you're adding > in your patch for one, and make it consistent with pxa2xx_build_groups() and > pxa2xx_build_state() for two. > > Therefore I'm not very thrilled by this patch and unless it fixes a defect in > the driver I'd rather not have it in. > > Cheers. > > -- > Robert
Powered by blists - more mailing lists