linux-kernel - Re: [PATCH] HID: add Asus macrokey support for Asus "Republic of Gamers" laptop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1612141119430.16984@cbobk.fhfr.pm>
Date:   Wed, 14 Dec 2016 11:20:31 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Chris Chiu <chiu@...lessm.com>
cc:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
        linux@...lessm.com
Subject: Re: [PATCH] HID: add Asus macrokey support for Asus "Republic of
 Gamers" laptop

On Mon, 12 Dec 2016, Chris Chiu wrote:

[ ... snip ... ]
> +static const struct hid_device_id asus_rog_devices[] = {
> +	{ HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK, USB_DEVICE_ID_ASUSTEK_ROG_MACROKEY1) },
> +	{ HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK, USB_DEVICE_ID_ASUSTEK_ROG_MACROKEY2) },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(hid, asus_rog_devices);

[ ... snip ... ]

In addition to what Benjamin said already, you also seem to be missing 
hid_have_special_driver[] entry for these VID/PIDs

Thanks,

-- 
Jiri Kosina
SUSE Labs