lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 15 Dec 2016 00:50:22 +0800
From:   Chris Chiu <chiu@...lessm.com>
To:     Jiri Kosina <jikos@...nel.org>
Cc:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
        linux@...lessm.com
Subject: Re: [PATCH] HID: add Asus macrokey support for Asus "Republic of
 Gamers" laptop

On Wed, Dec 14, 2016 at 6:20 PM, Jiri Kosina <jikos@...nel.org> wrote:
> On Mon, 12 Dec 2016, Chris Chiu wrote:
>
> [ ... snip ... ]
>> +static const struct hid_device_id asus_rog_devices[] = {
>> +     { HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK, USB_DEVICE_ID_ASUSTEK_ROG_MACROKEY1) },
>> +     { HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK, USB_DEVICE_ID_ASUSTEK_ROG_MACROKEY2) },
>> +     { }
>> +};
>> +MODULE_DEVICE_TABLE(hid, asus_rog_devices);
>
> [ ... snip ... ]
>
> In addition to what Benjamin said already, you also seem to be missing
> hid_have_special_driver[] entry for these VID/PIDs
>
> Thanks,
>
> --
> Jiri Kosina
> SUSE Labs
>

You're right. I forgot to add VID/PID in hid_have_special_driver in
this patch. I'll modify per Benjamin's suggestion and re-commit.
Thanks.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ