linux-kernel - Re: [PATCH] spi: SPI_FSL_DSPI should depend on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161214143713.3kl34okpr5vnuyc6@sirena.org.uk>
Date:   Wed, 14 Dec 2016 14:37:13 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Sanchayan Maity <maitysanchayan@...il.com>,
        linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: SPI_FSL_DSPI should depend on HAS_DMA

On Wed, Dec 14, 2016 at 01:28:05PM +0100, Geert Uytterhoeven wrote:
> If NO_DMA=y:

>     ERROR: "bad_dma_ops" [drivers/spi/spi-fsl-dspi.ko] undefined!

> Add a dependency on HAS_DMA to fix this.

Honestly I think we should just fix the architectures that don't support
DMA to provide compile out stubs for DMA, it seems like these
dependencies are more trouble than they're worth.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)