linux-kernel - Re: [PATCH] spi: SPI_FSL_DSPI should depend on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 14 Dec 2016 15:40:43 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     Sanchayan Maity <maitysanchayan@...il.com>,
        linux-spi <linux-spi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] spi: SPI_FSL_DSPI should depend on HAS_DMA

Hi Mark,

On Wed, Dec 14, 2016 at 3:37 PM, Mark Brown <broonie@...nel.org> wrote:
> On Wed, Dec 14, 2016 at 01:28:05PM +0100, Geert Uytterhoeven wrote:
>> If NO_DMA=y:
>
>>     ERROR: "bad_dma_ops" [drivers/spi/spi-fsl-dspi.ko] undefined!
>
>> Add a dependency on HAS_DMA to fix this.
>
> Honestly I think we should just fix the architectures that don't support
> DMA to provide compile out stubs for DMA, it seems like these
> dependencies are more trouble than they're worth.

Will that really help?

Then people will start adding "depends on HAS_DMA || COMPILE_TEST"
instead...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds