linux-kernel - Re: linux-next: build warning after merge of the btrfs-kdave tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161214151904.GE3620@suse.cz>
Date:   Wed, 14 Dec 2016 16:19:04 +0100
From:   David Sterba <dsterba@...e.cz>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
        Wang Xiaoguang <wangxg.fnst@...fujitsu.com>
Subject: Re: linux-next: build warning after merge of the btrfs-kdave tree

On Wed, Dec 07, 2016 at 09:38:19AM +1100, Stephen Rothwell wrote:
> Hi David,
> 
> On Mon, 28 Nov 2016 11:02:30 +1100 Stephen Rothwell <sfr@...b.auug.org.au> wrote:
> >
> > After merging the btrfs-kdave tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> > 
> > fs/btrfs/inode.c: In function 'run_delalloc_range':
> > fs/btrfs/inode.c:1219:9: warning: 'cur_end' may be used uninitialized in this function [-Wmaybe-uninitialized]
> >    start = cur_end + 1;
> >          ^
> > fs/btrfs/inode.c:1172:6: note: 'cur_end' was declared here
> >   u64 cur_end;
> >       ^
> > 
> > Introduced by commit
> > 
> >   cow_file_range_async ("btrfs: Introduce COMPRESS reserve type to fix false enospc for compression")
> > 
> > Presumably a false positive because ASSERT(0) panics?
> 
> Actually it does not if CONFIG_BTRFS_ASSERT is not set (which it isn't
> for the above build), so this is not a false positive.  I am still
> seeing this.

Sorry for late reply. I've updatd the for-next branch now, the patches
introducing the warning have been removed temporarily. Arnd Bergmann
sent a patch to fix the warning, I'll make sure to include it so the
warning does not reappear.