linux-kernel - Re: [PATCH 0/2] IB/rdmavt: cq ktrhead worker fix and API update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8f55e78f-0c3b-c2ff-14f7-844d68a5d212@redhat.com>
Date:   Wed, 14 Dec 2016 12:17:26 -0500
From:   Doug Ledford <dledford@...hat.com>
To:     "Dalessandro, Dennis" <dennis.dalessandro@...el.com>,
        "pmladek@...e.com" <pmladek@...e.com>,
        "Hefty, Sean" <sean.hefty@...el.com>
Cc:     "hal.rosenstock@...il.com" <hal.rosenstock@...il.com>,
        "tj@...nel.org" <tj@...nel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/2] IB/rdmavt: cq ktrhead worker fix and API update

On 10/20/2016 8:56 AM, Dalessandro, Dennis wrote:
> On Wed, 2016-10-19 at 14:07 +0200, Petr Mladek wrote:
>> The kthread worker API has been improved in 4.9-rc1. The 2nd
>> patch uses the new functions and simplifies the kthread worker
>> creation and destroying.
>>
>> I have found a possible race when working on the API conversion.
>> A proposed fix is in the 1st patch.
>>
>> Both changes are compile tested only. I did not find an easy way
>> how to test them at runtime.
>>
>> Petr Mladek (2):
>>   IB/rdmavt: Avoid queuing work into a destroyed cq kthread worker
>>   IB/rdmavt: Handle the kthread worker using the new API
>>
>>  drivers/infiniband/sw/rdmavt/cq.c | 64 +++++++++++++++++----------
>> ------------
>>  1 file changed, 27 insertions(+), 37 deletions(-)
> 
> Thanks for the patches. I'm going to take a closer look, I just now
> seen these.
> 
> -Denny
> 

These looked good to me, and you haven't objected, so I'm taking this
series.  Thanks.

-- 
Doug Ledford <dledford@...hat.com>
    GPG Key ID: 0E572FDD



Download attachment "signature.asc" of type "application/pgp-signature" (885 bytes)