linux-kernel - Re: [PATCH 1/1 linux-next] xfs: remove unnecessary return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ce30624-de82-f682-776c-7b6f1757026d@sandeen.net>
Date:   Wed, 14 Dec 2016 22:17:02 -0600
From:   Eric Sandeen <sandeen@...deen.net>
To:     Fabian Frederick <fabf@...net.be>,
        Dave Chinner <david@...morbit.com>,
        Eric Sandeen <sandeen@...hat.com>
Cc:     linux-xfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1 linux-next] xfs: remove unnecessary return

On 12/10/16 12:52 AM, Fabian Frederick wrote:
> Commit f7a136aee3c1
> ("xfs: several xattr functions can be void")
> 
> updated 2 end of function return 0 to return in void
> functions. Remove it.
> 
> Signed-off-by: Fabian Frederick <fabf@...net.be>

Oh, sure.  :)

Reviewed-by: Eric Sandeen <sandeen@...deen.net>

> ---
>  fs/xfs/xfs_attr_list.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/xfs/xfs_attr_list.c b/fs/xfs/xfs_attr_list.c
> index 97c45b6..5aa46c3 100644
> --- a/fs/xfs/xfs_attr_list.c
> +++ b/fs/xfs/xfs_attr_list.c
> @@ -433,7 +433,6 @@ xfs_attr3_leaf_list_int(
>  		cursor->offset++;
>  	}
>  	trace_xfs_attr_list_leaf_end(context);
> -	return;
>  }
>  
>  /*
> @@ -543,7 +542,6 @@ xfs_attr_put_listent(
>  	alist->al_offset[context->count++] = context->firstu;
>  	alist->al_count = context->count;
>  	trace_xfs_attr_list_add(context);
> -	return;
>  }
>  
>  /*
>