linux-kernel - Re: [PATCH 1/1 linux-next] xfs: remove unnecessary return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7e956ae4-bb46-383a-05fe-b9ac2eb9f855@sandeen.net>
Date:   Thu, 15 Dec 2016 11:53:18 -0600
From:   Eric Sandeen <sandeen@...deen.net>
To:     Fabian Frederick <fabf@...net.be>,
        Dave Chinner <david@...morbit.com>,
        Eric Sandeen <sandeen@...hat.com>
Cc:     linux-xfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1 linux-next] xfs: remove unnecessary return

On 12/14/16 10:17 PM, Eric Sandeen wrote:
> On 12/10/16 12:52 AM, Fabian Frederick wrote:
>> Commit f7a136aee3c1
>> ("xfs: several xattr functions can be void")
>>
>> updated 2 end of function return 0 to return in void
>> functions. Remove it.
>>
>> Signed-off-by: Fabian Frederick <fabf@...net.be>
> 
> Oh, sure.  :)
> 
> Reviewed-by: Eric Sandeen <sandeen@...deen.net>

On second thought, it seems to be quite common in 
xfs to have a last "return;" in void functions:

# grep -n -B1 ^} fs/xfs/*.c fs/xfs/*/*.c | grep "return;" | wc -l
14

so it's really just a style issue, and probably no reason
to change it in just these 2 cases... *shrug* dchinner, take
it or leave it as you see fit.  :)

-Eric
 
>> ---
>>  fs/xfs/xfs_attr_list.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/fs/xfs/xfs_attr_list.c b/fs/xfs/xfs_attr_list.c
>> index 97c45b6..5aa46c3 100644
>> --- a/fs/xfs/xfs_attr_list.c
>> +++ b/fs/xfs/xfs_attr_list.c
>> @@ -433,7 +433,6 @@ xfs_attr3_leaf_list_int(
>>  		cursor->offset++;
>>  	}
>>  	trace_xfs_attr_list_leaf_end(context);
>> -	return;
>>  }
>>  
>>  /*
>> @@ -543,7 +542,6 @@ xfs_attr_put_listent(
>>  	alist->al_offset[context->count++] = context->firstu;
>>  	alist->al_count = context->count;
>>  	trace_xfs_attr_list_add(context);
>> -	return;
>>  }
>>  
>>  /*
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>