linux-kernel - Re: [PATCH] watchdog: mpc8xxx: Remove unneeded linux/miscdevice.h include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8a154d8b-bee0-9a87-d95e-869778a44ca4@roeck-us.net>
Date:   Thu, 15 Dec 2016 19:35:18 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Corentin Labbe <clabbe.montjoie@...il.com>, wim@...ana.be,
        linux-watchdog@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: mpc8xxx: Remove unneeded linux/miscdevice.h
 include

On 12/15/2016 10:03 AM, Corentin Labbe wrote:
> watchdog/mpc8xxx_wdt.c does not use any miscdevice so this patch remove
> this unnecessary inclusion.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@...il.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/watchdog/mpc8xxx_wdt.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/watchdog/mpc8xxx_wdt.c b/drivers/watchdog/mpc8xxx_wdt.c
> index 5f2273a..366e5c7 100644
> --- a/drivers/watchdog/mpc8xxx_wdt.c
> +++ b/drivers/watchdog/mpc8xxx_wdt.c
> @@ -23,7 +23,6 @@
>  #include <linux/init.h>
>  #include <linux/kernel.h>
>  #include <linux/timer.h>
> -#include <linux/miscdevice.h>
>  #include <linux/of_address.h>
>  #include <linux/of_platform.h>
>  #include <linux/module.h>
>