linux-kernel - Re: [PATCH] hwmon: sch56xx: Remove unneeded linux/miscdevice.h include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fe75bd4e-9c8e-d22b-07d8-4c73b0efea3d@roeck-us.net>
Date:   Thu, 15 Dec 2016 19:35:52 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Corentin Labbe <clabbe.montjoie@...il.com>, jdelvare@...e.com,
        linux-hwmon@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: sch56xx: Remove unneeded linux/miscdevice.h
 include

On 12/15/2016 10:08 AM, Corentin Labbe wrote:
> drivers/hwmon/sch56xx-common.c does not contain any miscdevice so the
> inclusion of linux/miscdevice.h is uncessary.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@...il.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/hwmon/sch56xx-common.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/hwmon/sch56xx-common.c b/drivers/hwmon/sch56xx-common.c
> index 68c350c..bda3d52 100644
> --- a/drivers/hwmon/sch56xx-common.c
> +++ b/drivers/hwmon/sch56xx-common.c
> @@ -28,7 +28,6 @@
>  #include <linux/delay.h>
>  #include <linux/fs.h>
>  #include <linux/watchdog.h>
> -#include <linux/miscdevice.h>
>  #include <linux/uaccess.h>
>  #include <linux/slab.h>
>  #include "sch56xx-common.h"
>