linux-kernel - i2c: xiic: Strange clk_prepare_enable() in xiic_i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1481925285-594-1-git-send-email-khoroshilov@ispras.ru>
Date:   Sat, 17 Dec 2016 00:54:45 +0300
From:   Alexey Khoroshilov <khoroshilov@...ras.ru>
To:     Shubhrajyoti Datta <shubhraj@...inx.com>
Cc:     Alexey Khoroshilov <khoroshilov@...ras.ru>,
        Rob Herring <robh@...nel.org>,
        Wolfram Sang <wsa@...-dreams.de>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org, ldv-project@...uxtesting.org
Subject: i2c: xiic: Strange clk_prepare_enable() in xiic_i2c_remove()

Dear Shubhrajyoti,

Looking at 36ecbcab84d0 ("i2c: xiic: Implement power management")
it is not clear why clk_prepare_enable(i2c->clk) is required in
xiic_i2c_remove()?

It is enabled in xiic_i2c_probe() and disabled/enabled in
cdns_i2c_runtime_suspend()/cdns_i2c_runtime_resume().

Could you please clarify the point.

--
Alexey Khoroshilov
Linux Verification Center, ISPRAS
web: http://linuxtesting.org