linux-kernel - Re: [PATCH] ACPI/CPC: Don't try to clean up uninitialized CPC data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <11b1b0a4-0ea6-9738-9575-5e038adf8979@oracle.com>
Date:   Fri, 16 Dec 2016 17:02:28 -0500
From:   Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:     "Prakash, Prashanth" <pprakash@...eaurora.org>, rjw@...ysocki.net,
        lenb@...nel.org
Cc:     linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI/CPC: Don't try to clean up uninitialized CPC data

On 12/16/2016 04:52 PM, Prakash, Prashanth wrote:
> Hi Boris,
>
> On 12/16/2016 11:35 AM, Boris Ostrovsky wrote:
>> If acpi_cppc_processor_probe() had not executed successfully (for
>> example, if _CPC object was not found) then cpc_desc_ptr for that
>> processor will be invalid.
>>
>> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@...cle.com>
>> ---
>>  drivers/acpi/cppc_acpi.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
>> index d0d0504..5bba26e 100644
>> --- a/drivers/acpi/cppc_acpi.c
>> +++ b/drivers/acpi/cppc_acpi.c
>> @@ -824,6 +824,8 @@ void acpi_cppc_processor_exit(struct acpi_processor *pr)
>>  	void __iomem *addr;
>>  
>>  	cpc_ptr = per_cpu(cpc_desc_ptr, pr->id);
>> +	if (!cpc_ptr)
>> +		return;
>>  
>>  	/* Free all the mapped sys mem areas for this CPU */
>>  	for (i = 2; i < cpc_ptr->num_entries; i++) {
> I think a recent patch from Sebastian fixed the same issue.
> https://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=9e9d68dad58c70f40f50adfeabd2fdaa39a743fd

Ah, excellent! Thanks.

-boris