linux-kernel - Re: [PATCH] staging: emxx_udc: Fix CamelCase styling issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1482082825.2431.5.camel@perches.com>
Date:   Sun, 18 Dec 2016 09:40:25 -0800
From:   Joe Perches <joe@...ches.com>
To:     Afonso Bordado <afonsobordado@....co>, gregkh@...uxfoundation.org
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: emxx_udc: Fix CamelCase styling issue

On Sun, 2016-12-18 at 16:46 +0000, Afonso Bordado wrote:
> Converts from CamelCase to the recommended style.
> 
> Signed-off-by: Afonso Bordado <afonsobordado@....co>
> ---
>  drivers/staging/emxx_udc/emxx_udc.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
> index 3f42fa8..cf5cdd8 100644
> --- a/drivers/staging/emxx_udc/emxx_udc.c
> +++ b/drivers/staging/emxx_udc/emxx_udc.c
> @@ -553,25 +553,25 @@ static void _nbu2ss_dma_unmap_single(
>  
>  /*-------------------------------------------------------------------------*/
>  /* Endpoint 0 OUT Transfer (PIO) */
> -static int EP0_out_PIO(struct nbu2ss_udc *udc, u8 *pBuf, u32 length)
> +static int EP0_out_PIO(struct nbu2ss_udc *udc, u8 *p_buf, u32 length)
>  {
>  	u32		i;
>  	int		nret   = 0;
> -	u32		iWordLength = 0;
> -	union usb_reg_access *pBuf32 = (union usb_reg_access *)pBuf;
> +	u32		i_word_length = 0;
> +	union usb_reg_access *p_buf32 = (union usb_reg_access *)p_buf;
>  
>  	/*------------------------------------------------------------*/
>  	/* Read Length */
> -	iWordLength = length / sizeof(u32);
> +	i_word_length = length / sizeof(u32);
>  
>  	/*------------------------------------------------------------*/
>  	/* PIO Read */
> -	if (iWordLength) {
> -		for (i = 0; i < iWordLength; i++) {
> -			pBuf32->dw = _nbu2ss_readl(&udc->p_regs->EP0_READ);
> -			pBuf32++;
> +	if (i_word_length) {
> +		for (i = 0; i < i_word_length; i++) {
> +			p_buf32->dw = _nbu2ss_readl(&udc->p_regs->EP0_READ);
> +			p_buf32++;
>  		}
> -		nret = iWordLength * sizeof(u32);
> +		nret = i_word_length * sizeof(u32);
>  	}
>  
>  	return nret;

Instead of merely converting Hungarian CamelCase to lowercase
with underscores where word transitions occurred, try reading
the code and making sense of what it does to perhaps find a
better variable name instead.  Maybe eliminate the variable
altogether.

iWordLength could be reads or numreads

btw: what happens if length is not a multiple of sizeof(u32)?

nret is more commonly ret
p_buf is also not common linux naming, buf is more common.