linux-kernel - Re: [PATCH] fix code alignment with open parenthesis in drivers/staging/fbtft/fb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b1b344ce-4a7b-7529-364b-fc02cabad41e@matheina.com>
Date:   Sun, 18 Dec 2016 11:43:25 -0600
From:   Scott Matheina <scott@...heina.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     thomas.petazzoni@...e-electrons.com, noralf@...nnes.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fix code alignment with open parenthesis in
 drivers/staging/fbtft/fb_agm1264k-fl.c



On 12/18/2016 01:46 AM, Greg KH wrote:
> On Sat, Dec 17, 2016 at 08:42:53PM -0600, Scott Matheina wrote:
>> Signed-off-by: Scott Matheina <scott@...heina.com>
> I can't take patches without any changelog text :(
Yah. Forgot to add the description. Added for v2.
>> ---
>>   drivers/staging/fbtft/fb_agm1264k-fl.c | 17 ++++++++++-------
>>   1 file changed, 10 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/staging/fbtft/fb_agm1264k-fl.c b/drivers/staging/fbtft/fb_agm1264k-fl.c
>> index a6e3af7..4e371ed 100644
>> --- a/drivers/staging/fbtft/fb_agm1264k-fl.c
>> +++ b/drivers/staging/fbtft/fb_agm1264k-fl.c
>> @@ -186,8 +186,9 @@ static void write_reg8_bus8(struct fbtft_par *par, int len, ...)
>>
>>   		va_end(args);
>>   		fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par,
>> -			par->info->device, u8, buf, len, "%s: ", __func__);
>> -	}
>> +				  par->info->device, u8, buf, len,
>> +				  "%s: ", __func__);
>> +}
> I don't think you did this correctly, do you?
I looked at this, and made a change to the line break, but if you're 
talking about
the code itself then I'll have to dig into the books to figure that out. 
Starting small
and learn from reading the code and making some small changes while I figure
it out.