linux-kernel - [PATCH] vfs: return EOPNOTSUPP when ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20161218185727.2209-1-kerolasa@iki.fi>
Date:   Sun, 18 Dec 2016 18:57:27 +0000
From:   Sami Kerola <kerolasa@....fi>
To:     Al Viro <viro@...iv.linux.org.uk>, linux-fsdevel@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Sami Kerola <kerolasa@....fi>
Subject: [PATCH] vfs: return EOPNOTSUPP when ioctl_fsthaw() is not supported

An attempt to freeze a filesystem that does not support such operation is
reported as EOPNOTSUPP to user.  Running unfreeze to the same filesystem
returns EINVAL.  Later is a little misleading, users can mix that message
with return value from unfreezing when filesystem is not frozen.

Signed-off-by: Sami Kerola <kerolasa@....fi>
---
 fs/ioctl.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/fs/ioctl.c b/fs/ioctl.c
index cb9b02940805..1d6372ef4008 100644
--- a/fs/ioctl.c
+++ b/fs/ioctl.c
@@ -566,6 +566,10 @@ static int ioctl_fsthaw(struct file *filp)
 	if (!capable(CAP_SYS_ADMIN))
 		return -EPERM;
 
+	/* If filesystem doesn't support thaw feature, return. */
+	if (!sb->s_op->unfreeze_fs)
+		return -EOPNOTSUPP;
+
 	/* Thaw */
 	if (sb->s_op->thaw_super)
 		return sb->s_op->thaw_super(sb);
-- 
2.11.0