linux-kernel - Re: [PATCH 8/8] extcon: axp288: Fix the module not auto-loading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <58578380.7000901@samsung.com>
Date:   Mon, 19 Dec 2016 15:51:44 +0900
From:   Chanwoo Choi <cw00.choi@...sung.com>
To:     Hans de Goede <hdegoede@...hat.com>,
        MyungJoo Ham <myungjoo.ham@...sung.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 8/8] extcon: axp288: Fix the module not auto-loading

Hi Hans,

On 2016년 12월 19일 09:13, Hans de Goede wrote:
> Add a MODULE_DEVICE_TABLE to fix the module not auto-loading.
> 
> Signed-off-by: Hans de Goede <hdegoede@...hat.com>
> ---
>  drivers/extcon/extcon-axp288.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c
> index a27ee68..509a5f9 100644
> --- a/drivers/extcon/extcon-axp288.c
> +++ b/drivers/extcon/extcon-axp288.c
> @@ -320,8 +320,15 @@ static int axp288_extcon_probe(struct platform_device *pdev)
>  	return 0;
>  }
>  
> +static const struct platform_device_id axp288_extcon_table[] = {
> +	{ .name = "axp288_extcon" },
> +	{},
> +};
> +MODULE_DEVICE_TABLE(platform, axp288_extcon_table);
> +
>  static struct platform_driver axp288_extcon_driver = {
>  	.probe = axp288_extcon_probe,
> +	.id_table = axp288_extcon_table,
>  	.driver = {
>  		.name = "axp288_extcon",
>  	},
> 

Looks good to me.
Acked-by: Chanwoo Choi <cw00.choi@...sung.com>

-- 
Regards,
Chanwoo Choi