linux-kernel - Re: [PATCH] scripts: checkincludes: add exit message for no duplicates found

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 19 Dec 2016 11:47:47 +0100
From:   Michal Marek <mmarek@...e.com>
To:     Cheah Kok Cheong <thrust73@...il.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scripts: checkincludes: add exit message for no
 duplicates found

On 2016-12-18 13:35, Cheah Kok Cheong wrote:
> If no duplicates found, inform user.
> 
> Signed-off-by: Cheah Kok Cheong <thrust73@...il.com>
> ---
>  scripts/checkincludes.pl | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/scripts/checkincludes.pl b/scripts/checkincludes.pl
> index 97b2c61..2bf234c 100755
> --- a/scripts/checkincludes.pl
> +++ b/scripts/checkincludes.pl
> @@ -37,6 +37,13 @@ if ($#ARGV >= 1) {
>  	}
>  }
>  
> +my $dup_counter = 0;
> +
> +sub nodup_count {
> +	++$dup_counter;
> +	return;
> +}

I don't think it's necessary to have a function only to increment a
variable.

Michal