linux-kernel - Re: [PATCH] scripts: checkincludes: add exit message for no duplicates found

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161220091020.GA2549@linux-Precision-WorkStation-T5500>
Date:   Tue, 20 Dec 2016 17:10:21 +0800
From:   Cheah Kok Cheong <thrust73@...il.com>
To:     Michal Marek <mmarek@...e.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scripts: checkincludes: add exit message for no
 duplicates found

On Mon, Dec 19, 2016 at 11:47:47AM +0100, Michal Marek wrote:
> On 2016-12-18 13:35, Cheah Kok Cheong wrote:
> > If no duplicates found, inform user.
> > 
> > Signed-off-by: Cheah Kok Cheong <thrust73@...il.com>
> > ---
> >  scripts/checkincludes.pl | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> > 
> > diff --git a/scripts/checkincludes.pl b/scripts/checkincludes.pl
> > index 97b2c61..2bf234c 100755
> > --- a/scripts/checkincludes.pl
> > +++ b/scripts/checkincludes.pl
> > @@ -37,6 +37,13 @@ if ($#ARGV >= 1) {
> >  	}
> >  }
> >  
> > +my $dup_counter = 0;
> > +
> > +sub nodup_count {
> > +	++$dup_counter;
> > +	return;
> > +}
> 
> I don't think it's necessary to have a function only to increment a
> variable.
> 
> Michal

Sorry do you mean the subroutine is not required and the "variable" is
best placed inside directly?

Thanks.
CheahKC