linux-kernel - Re: [PATCH] Documentation/unaligned-memory-access.txt: fix incorrect comparison operator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 20 Dec 2016 12:58:37 +0300
From:   Ozgur Karatas <okaratas@...ber.fsf.org>
To:     Jonathan Corbet <corbet@....net>,
        Cihangir Akturk <cakturk@...il.com>
Cc:     "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Documentation/unaligned-memory-access.txt: fix incorrect comparison operator

20.12.2016, 01:13, "Jonathan Corbet" <corbet@....net>:
> On Mon, 19 Dec 2016 23:53:40 +0200
> Cihangir Akturk <cakturk@...il.com> wrote:
>
>>  In the actual implementation ether_addr_equal function tests for equality to 0
>>  when returning. It seems in commit 0d74c4 it is somehow overlooked to change
>>  this operator to reflect the actual function.
>
> I received this patch two days ago; has something changed that you're
> sending it again?

My opinion, the patch its update. The assignment of "!=0" has already been fixed with patch. 
I tested it.

> Meanwhile, there was a question from Ozgur Karatas on the patch, but I've
> not yet seen your response.

If you see fit your approval.

> Thanks,
>
> jon

Regards,

~Ozgur