linux-kernel - Re: [PATCH] rtlwifi: Fix kernel oops introduced with commit e49656147359

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c3779ada-0018-3ec5-cdb2-c470f9ca467e@lwfinger.net>
Date:   Tue, 20 Dec 2016 09:25:40 -0600
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Kalle Valo <kvalo@...eaurora.org>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        devel@...verdev.osuosl.org, linux-wireless@...r.kernel.org,
        linux-kernel@...r.kernel.org, driver-devel@...r.kernel.org,
        Stable <stable@...r.kernel.org>,
        Wei Yongjun <weiyongjun1@...wei.com>
Subject: Re: [PATCH] rtlwifi: Fix kernel oops introduced with commit
 e49656147359

On 12/20/2016 05:21 AM, Kalle Valo wrote:
> Larry Finger <Larry.Finger@...inger.net> writes:
>
>> With commit e49656147359 {"rtlwifi: Use dev_kfree_skb_irq instead of
>> kfree_skb"), the method used to free an skb was changed because the
>> kfree_skb() was inside a spinlock. What was forgotten is that kfree_skb()
>> guards against a NULL value for the argument. Routine dev_kfree_skb_irq()
>> does not, and a test is needed to prevent kernel panics.
>>
>> Fixes: commit e49656147359 {"rtlwifi: Use dev_kfree_skb_irq instead of kfree_skb")
>
> This should be:
>
> Fixes: e49656147359 ("rtlwifi: Use dev_kfree_skb_irq instead of kfree_skb")
>
>> Signed-off-by: Larry Finger <Larry.Finger@...inger.net>
>> Cc: Stable <stable@...r.kernel.org> (4.9+)
>
> And this:
>
> Cc: Stable <stable@...r.kernel.org> # 4.9+
>
> I can fix both of them.
>
>> Cc: Wei Yongjun <weiyongjun1@...wei.com>
>> ---
>> Kalle,
>>
>> This change should be sent to mainline during the 4.10 merge period,
>> or as soon as possible.
>
> Ok, I'll queue this to 4.10. Most likely I'll send a pull request to
> Dave later this week or so.

Thanks for the suggested changes, and for the quick action.

Larry