linux-kernel - Re: [PATCH] NTB: Fix 'request_irq()' and 'free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161221165212.GC32599@kudzu.us>
Date:   Wed, 21 Dec 2016 11:52:12 -0500
From:   Jon Mason <jdmason@...zu.us>
To:     Dave Jiang <dave.jiang@...el.com>
Cc:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Xiangliang.Yu@....com, Allen.Hubbe@....com,
        linux-ntb@...glegroups.com, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] NTB: Fix 'request_irq()' and 'free_irq()' inconsistancy

On Mon, Dec 19, 2016 at 10:04:24AM -0700, Dave Jiang wrote:
> 
> 
> On 12/18/2016 10:52 PM, Christophe JAILLET wrote:
> > 'request_irq()' and 'free_irq()' should have the same 'dev_id'.
> > 
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> 
> Acking the Intel driver portion.
> Acked-by: Dave Jiang <dave.jiang@...el.com>

Applied to the ntb git branch

Thanks,
Jon

> 
> > ---
> >  drivers/ntb/hw/amd/ntb_hw_amd.c     | 2 +-
> >  drivers/ntb/hw/intel/ntb_hw_intel.c | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/ntb/hw/amd/ntb_hw_amd.c b/drivers/ntb/hw/amd/ntb_hw_amd.c
> > index 6ccba0d862df..a48c3e085eab 100644
> > --- a/drivers/ntb/hw/amd/ntb_hw_amd.c
> > +++ b/drivers/ntb/hw/amd/ntb_hw_amd.c
> > @@ -598,7 +598,7 @@ static int ndev_init_isr(struct amd_ntb_dev *ndev,
> >  
> >  err_msix_request:
> >  	while (i-- > 0)
> > -		free_irq(ndev->msix[i].vector, ndev);
> > +		free_irq(ndev->msix[i].vector, &ndev->vec[i]);
> >  	pci_disable_msix(pdev);
> >  err_msix_enable:
> >  	kfree(ndev->msix);
> > diff --git a/drivers/ntb/hw/intel/ntb_hw_intel.c b/drivers/ntb/hw/intel/ntb_hw_intel.c
> > index 7310a261c858..2413600aae30 100644
> > --- a/drivers/ntb/hw/intel/ntb_hw_intel.c
> > +++ b/drivers/ntb/hw/intel/ntb_hw_intel.c
> > @@ -472,7 +472,7 @@ static int ndev_init_isr(struct intel_ntb_dev *ndev,
> >  
> >  err_msix_request:
> >  	while (i-- > 0)
> > -		free_irq(ndev->msix[i].vector, ndev);
> > +		free_irq(ndev->msix[i].vector, &ndev->vec[i]);
> >  	pci_disable_msix(pdev);
> >  err_msix_enable:
> >  	kfree(ndev->msix);
> > 
> 
> -- 
> You received this message because you are subscribed to the Google Groups "linux-ntb" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-ntb+unsubscribe@...glegroups.com.
> To post to this group, send email to linux-ntb@...glegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/linux-ntb/56b16dd5-b83b-e8b0-bf79-2dd2bc56f1e1%40intel.com.
> For more options, visit https://groups.google.com/d/optout.