linux-kernel - [v1] gpu: drm: sti: sti_vtac:- Handle return NULL error from devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1482297755-4620-1-git-send-email-arvind.yadav.cs@gmail.com>
Date:   Wed, 21 Dec 2016 10:52:35 +0530
From:   Arvind Yadav <arvind.yadav.cs@...il.com>
To:     benjamin.gaignard@...aro.org, vincent.abriou@...com,
        airlied@...ux.ie
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: [v1] gpu: drm: sti: sti_vtac:- Handle return NULL error from devm_ioremap_nocache

Here, If devm_ioremap_nocache will fail. It will return NULL.
Kernel can run into a NULL-pointer dereference. This error check
will avoid NULL pointer dereference.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
---
 drivers/gpu/drm/sti/sti_vtac.c |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/sti/sti_vtac.c b/drivers/gpu/drm/sti/sti_vtac.c
index cf7fe8a..dd749e9 100644
--- a/drivers/gpu/drm/sti/sti_vtac.c
+++ b/drivers/gpu/drm/sti/sti_vtac.c
@@ -191,6 +191,10 @@ static int sti_vtac_probe(struct platform_device *pdev)
 	if (res) {
 		vtac->phy_regs = devm_ioremap_nocache(dev, res->start,
 						 resource_size(res));
+			if (!vtac->phy_regs) {
+				DRM_ERROR("failed to remap I/O memory\n");
+				return -ENOMEM;
+			}
 		sti_vtac_tx_set_config(vtac);
 	} else {
 
-- 
1.7.9.5