linux-kernel - Re: [v1] gpu: drm: sti: sti_vtac:- Handle return NULL error from devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1e787556-a90a-5ccf-29b8-e791f4063ebf@st.com>
Date:   Wed, 4 Jan 2017 09:31:40 +0000
From:   Vincent ABRIOU <vincent.abriou@...com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>,
        "benjamin.gaignard@...aro.org" <benjamin.gaignard@...aro.org>,
        "airlied@...ux.ie" <airlied@...ux.ie>
CC:     "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [v1] gpu: drm: sti: sti_vtac:- Handle return NULL error from
 devm_ioremap_nocache

Hi Arvind,

Thank for this patch.
Since sti_vtac.c file is deprecated, I rather suppress the sti_vtac.c file.
I just push a new patch to suppress it.

Thank for pointing this out.
Br
Vincent

On 12/21/2016 06:22 AM, Arvind Yadav wrote:
> Here, If devm_ioremap_nocache will fail. It will return NULL.
> Kernel can run into a NULL-pointer dereference. This error check
> will avoid NULL pointer dereference.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---
>  drivers/gpu/drm/sti/sti_vtac.c |    4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/sti/sti_vtac.c b/drivers/gpu/drm/sti/sti_vtac.c
> index cf7fe8a..dd749e9 100644
> --- a/drivers/gpu/drm/sti/sti_vtac.c
> +++ b/drivers/gpu/drm/sti/sti_vtac.c
> @@ -191,6 +191,10 @@ static int sti_vtac_probe(struct platform_device *pdev)
>  	if (res) {
>  		vtac->phy_regs = devm_ioremap_nocache(dev, res->start,
>  						 resource_size(res));
> +			if (!vtac->phy_regs) {
> +				DRM_ERROR("failed to remap I/O memory\n");
> +				return -ENOMEM;
> +			}
>  		sti_vtac_tx_set_config(vtac);
>  	} else {
>
>