linux-kernel - Re: [PATCH] x86/efi Fix regression in efi_arch_mem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1482402107.3184.3.camel@redhat.com>
Date:   Thu, 22 Dec 2016 11:21:47 +0100
From:   Petr Oros <poros@...hat.com>
To:     Matt Fleming <matt@...eblueprint.co.uk>
Cc:     ard.biesheuvel@...aro.org, tglx@...utronix.de, mingo@...hat.com,
        hpa@...or.com, x86@...nel.org, linux-efi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/efi Fix regression in efi_arch_mem_reserve

Matt Fleming píše v Wed 21. 12. 2016 v 22:30 +0000:
> On Wed, 21 Dec, at 02:11:38PM, Petr Oros wrote:
> > 
> >   Booting on EFI with ESRT table has been stop since commit:
> >     8e80632 efi/esrt: Use efi_mem_reserve() and avoid a kmalloc()
> > 
> >   This is caused by this commit:
> >     816e761 efi: Allow drivers to reserve boot services forever
> > 
> >   Problem is, that efi_memmap_insert need memory aligned
> >   on EFI_PAGE_SIZE. If memory not aligned, efi_memmap_insert
> >   just return and let efi.memmap in inconsistent state.
> >   This breaking boot.
> > 
> >   Tested in my machine, which stop booting
> >   after upgrade to 4.9
> > 
> > Signed-off-by: Petr Oros <poros@...hat.com>
> > ---
> >  arch/x86/platform/efi/quirks.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Could you provide some more information? Why does efi_memmap_insert()
> require this alignment? How does booting "break"? If you see an Oops,
> please post it here.

Ooops, sorry, please ignore this patch. I overlooked efi_memmap_insert
argument order. I bisected kernel and this patch breaking kernel boot
but from other reason. Provided patch fixed kernel booting issue by
mistake.

-Petr