linux-kernel - Re: [PATCH V6 04/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream Detection and IO Coalescing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201612231341.YfIF6ryx%fengguang.wu@intel.com>
Date:   Fri, 23 Dec 2016 14:03:03 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Sasikumar Chandrasekaran <sasikumar.pc@...adcom.com>
Cc:     kbuild-all@...org, jejb@...nel.org, hch@...radead.org,
        linux-scsi@...r.kernel.org, Sathya.Prakash@...adcom.com,
        linux-kernel@...r.kernel.org, christopher.owens@...adcom.com,
        kiran-kumar.kasturi@...adcom.com, thenzl@...hat.com,
        sasikumar.pc@...adcom.com
Subject: Re: [PATCH V6 04/11] megaraid_sas: SAS3.5 Generic Megaraid
 Controllers Stream Detection and IO Coalescing

Hi Sasikumar,

[auto build test WARNING on scsi/for-next]
[also build test WARNING on next-20161223]
[cannot apply to v4.9]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Sasikumar-Chandrasekaran/megaraid_sas-Updates-for-scsi-next/20161223-103256
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
config: x86_64-randconfig-ne0-12231250 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   In file included from include/linux/linkage.h:4:0,
                    from include/linux/kernel.h:6,
                    from drivers/scsi/megaraid/megaraid_sas_fusion.c:34:
   drivers/scsi/megaraid/megaraid_sas_fusion.c: In function 'megasas_stream_detect':
   include/linux/compiler.h:149:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
     ^
   include/linux/compiler.h:147:23: note: in expansion of macro '__trace_if'
    #define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) )
                          ^~~~~~~~~~
>> drivers/scsi/megaraid/megaraid_sas_fusion.c:1744:3: note: in expansion of macro 'if'
      if ((io_info->ldStartBlock != current_sd->next_seq_lba)
      ^~
   drivers/scsi/megaraid/megaraid_sas_fusion.c:1751:4: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
       cmd->io_request->RaidContext.raid_context_g35.stream_detected = true;
       ^~~

vim +/if +1744 drivers/scsi/megaraid/megaraid_sas_fusion.c

  1728		struct STREAM_DETECT *current_sd;
  1729		/* find possible stream */
  1730		for (i = 0; i < MAX_STREAMS_TRACKED; ++i) {
  1731			stream_num =
  1732			(*track_stream >> (i * BITS_PER_INDEX_STREAM)) &
  1733				STREAM_MASK;
  1734			current_sd = &current_ld_sd->stream_track[stream_num];
  1735		/* if we found a stream, update the raid
  1736		*  context and also update the mruBitMap
  1737		*/
  1738		/*	boundary condition */
  1739		if ((current_sd->next_seq_lba) &&
  1740			(io_info->ldStartBlock >= current_sd->next_seq_lba) &&
  1741			(io_info->ldStartBlock <= (current_sd->next_seq_lba+32)) &&
  1742			(current_sd->is_read == io_info->isRead)) {
  1743	
> 1744			if ((io_info->ldStartBlock != current_sd->next_seq_lba)
  1745				&& ((!io_info->isRead) || (!is_read_ahead)))
  1746				/*
  1747				* Once the API availible we need to change this.
  1748				* At this point we are not allowing any gap
  1749				*/
  1750				continue;
  1751				cmd->io_request->RaidContext.raid_context_g35.stream_detected = true;
  1752				current_sd->next_seq_lba =

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (23448 bytes)