linux-kernel - Re: [v1] i2c: busses: i2c-designware-pcidrv:- Unmap region obtained by pcim_iomap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f99b90a1-88b3-4971-2a0f-842f36af171a@linux.intel.com>
Date:   Fri, 23 Dec 2016 13:27:51 +0200
From:   Jarkko Nikula <jarkko.nikula@...ux.intel.com>
To:     Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     wsa@...-dreams.de, andriy.shevchenko@...ux.intel.com,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [v1] i2c: busses: i2c-designware-pcidrv:- Unmap region obtained
 by pcim_iomap_regions

On 12/23/2016 12:44 PM, Mika Westerberg wrote:
> On Fri, Dec 23, 2016 at 03:41:33PM +0530, Arvind Yadav wrote:
>> Release IO memory mapping, if i2c_dw_pci_probe is not successful.
>
> Point of pcim_iomap_regions() is that the regions are released
> automatically. So there is no need for explicit release.
>
Please see commit 76cf3fc844a4 ("i2c-designware-pci: use managed 
functions pcim_* and devm_*") how it simplified error handling here.

-- 
Jarkko