linux-kernel - Re: [v1] i2c: busses: i2c-designware-pcidrv:- Unmap region obtained by pcim_iomap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 23 Dec 2016 13:55:21 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>,
        jarkko.nikula@...ux.intel.com, wsa@...-dreams.de,
        mika.westerberg@...ux.intel.com
Cc:     linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [v1] i2c: busses: i2c-designware-pcidrv:- Unmap region obtained
 by pcim_iomap_regions

On Fri, 2016-12-23 at 15:41 +0530, Arvind Yadav wrote:
> Release IO memory mapping, if i2c_dw_pci_probe is not successful.
> 

Second NAK, and seems (due to kbot message) you didn't even bother to
compile test.

What are you doing?

> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---
>  drivers/i2c/busses/i2c-designware-pcidrv.c |   12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c
> b/drivers/i2c/busses/i2c-designware-pcidrv.c
> index d6423cf..75e6e27 100644
> --- a/drivers/i2c/busses/i2c-designware-pcidrv.c
> +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c
> @@ -228,8 +228,10 @@ static int i2c_dw_pci_probe(struct pci_dev *pdev,
>  	}
>  
>  	dev = devm_kzalloc(&pdev->dev, sizeof(struct dw_i2c_dev),
> GFP_KERNEL);
> -	if (!dev)
> -		return -ENOMEM;
> +	if (!dev) {
> +		r = -ENOMEM;
> +		goto error;
> +	}
>  
>  	dev->clk = NULL;
>  	dev->controller = controller;
> @@ -241,7 +243,7 @@ static int i2c_dw_pci_probe(struct pci_dev *pdev,
>  	if (controller->setup) {
>  		r = controller->setup(pdev, controller);
>  		if (r)
> -			return r;
> +			goto error;
>  	}
>  
>  	dev->functionality = controller->functionality |
> @@ -270,7 +272,7 @@ static int i2c_dw_pci_probe(struct pci_dev *pdev,
>  
>  	r = i2c_dw_probe(dev);
>  	if (r)
> -		return r;
> +		goto error;
>  
>  	pm_runtime_set_autosuspend_delay(&pdev->dev, 1000);
>  	pm_runtime_use_autosuspend(&pdev->dev);
> @@ -278,6 +280,8 @@ static int i2c_dw_pci_probe(struct pci_dev *pdev,
>  	pm_runtime_allow(&pdev->dev);
>  
>  	return 0;
> +error:
> +	pcim_iounmap_regions(pdev, 1 << 0);
>  }
>  
>  static void i2c_dw_pci_remove(struct pci_dev *pdev)

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy