linux-kernel - Re: [v2 7/7] x86: Enable User-Mode Instruction Prevention

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201612241127.LoQqY20C%fengguang.wu@intel.com>
Date:   Sat, 24 Dec 2016 11:15:05 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>
Cc:     kbuild-all@...org, Ingo Molnar <mingo@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Borislav Petkov <bp@...e.de>,
        Andy Lutomirski <luto@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        linux-kernel@...r.kernel.org, x86@...nel.org,
        linux-msdos@...r.kernel.org, wine-devel@...ehq.org,
        Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "H . Peter Anvin" <hpa@...or.com>, Brian Gerst <brgerst@...il.com>,
        Chen Yucong <slaoub@...il.com>,
        Chris Metcalf <cmetcalf@...lanox.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Fenghua Yu <fenghua.yu@...el.com>,
        Huang Rui <ray.huang@....com>, Jiri Slaby <jslaby@...e.cz>,
        Jonathan Corbet <corbet@....net>,
        "Michael S . Tsirkin" <mst@...hat.com>,
        Paul Gortmaker <paul.gortmaker@...driver.com>,
        "Ravi V . Shankar" <ravi.v.shankar@...el.com>,
        Shuah Khan <shuah@...nel.org>,
        Vlastimil Babka <vbabka@...e.cz>,
        Tony Luck <tony.luck@...el.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        "Liang Z . Li" <liang.z.li@...el.com>,
        Alexandre Julliard <julliard@...ehq.org>,
        Stas Sergeev <stsp@...t.ru>
Subject: Re: [v2 7/7] x86: Enable User-Mode Instruction Prevention

Hi Ricardo,

[auto build test WARNING on tip/auto-latest]
[also build test WARNING on next-20161223]
[cannot apply to tip/x86/core v4.9]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Ricardo-Neri/x86-enable-User-Mode-Instruction-Prevention/20161224-094338
config: x86_64-acpi-redef (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   arch/x86/kernel/umip.c: In function '__identify_insn':
>> arch/x86/kernel/umip.c:65:1: warning: control reaches end of non-void function [-Wreturn-type]
    }
    ^

vim +65 arch/x86/kernel/umip.c

78301541 Ricardo Neri 2016-12-23  49  			return UMIP_SGDT;
78301541 Ricardo Neri 2016-12-23  50  		case 1:
78301541 Ricardo Neri 2016-12-23  51  			return UMIP_SIDT;
78301541 Ricardo Neri 2016-12-23  52  		case 4:
78301541 Ricardo Neri 2016-12-23  53  			return UMIP_SMSW;
78301541 Ricardo Neri 2016-12-23  54  		default:
78301541 Ricardo Neri 2016-12-23  55  			return -EINVAL;
78301541 Ricardo Neri 2016-12-23  56  		}
78301541 Ricardo Neri 2016-12-23  57  	} else if (insn->opcode.bytes[1] == 0x0) {
78301541 Ricardo Neri 2016-12-23  58  		if (X86_MODRM_REG(insn->modrm.value) == 0)
78301541 Ricardo Neri 2016-12-23  59  			return UMIP_SLDT;
78301541 Ricardo Neri 2016-12-23  60  		else if (X86_MODRM_REG(insn->modrm.value) == 1)
78301541 Ricardo Neri 2016-12-23  61  			return UMIP_STR;
78301541 Ricardo Neri 2016-12-23  62  		else
78301541 Ricardo Neri 2016-12-23  63  			return -EINVAL;
78301541 Ricardo Neri 2016-12-23  64  	}
78301541 Ricardo Neri 2016-12-23 @65  }
78301541 Ricardo Neri 2016-12-23  66  
78301541 Ricardo Neri 2016-12-23  67  static int __emulate_umip_insn(struct insn *insn, enum umip_insn umip_inst,
78301541 Ricardo Neri 2016-12-23  68  			       unsigned char *data, int *data_size)
78301541 Ricardo Neri 2016-12-23  69  {
78301541 Ricardo Neri 2016-12-23  70  	unsigned long const *dummy_base_addr;
78301541 Ricardo Neri 2016-12-23  71  	unsigned short dummy_limit = 0;
78301541 Ricardo Neri 2016-12-23  72  	unsigned short dummy_value = 0;
78301541 Ricardo Neri 2016-12-23  73  

:::::: The code at line 65 was first introduced by commit
:::::: 7830154191c35fde49ef59c2b9328f6b32203be4 x86: Add emulation code for UMIP instructions

:::::: TO: Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>
:::::: CC: 0day robot <fengguang.wu@...el.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (28924 bytes)