lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 25 Dec 2016 13:07:17 +0300 From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> To: Thomas Preisner <thomas.preisner+linux@....de> Cc: dave@...dillows.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, linux-kernel@...cs.fau.de, milan.stephan+linux@....de Subject: Re: [PATCH v3 2/2] drivers: net: ethernet: 3com: fix return value Hello! On 12/25/2016 3:30 AM, Thomas Preisner wrote: > In some cases the return value of a failing function is not being used > and the function typhoon_init_one() returns another negative error > code instead. > > Signed-off-by: Thomas Preisner <thomas.preisner+linux@....de> > Signed-off-by: Milan Stephan <milan.stephan+linux@....de> > --- > drivers/net/ethernet/3com/typhoon.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) In addition to what DaveM said, your choise of the subject prefixes is too wide -- it would seem that you're fixing all 3com drivers, while you're only fixing typhoon. That "typhoon:" alone would have been an appropriate prefix. MBR, Sergei
Powered by blists - more mailing lists