linux-kernel - Re: [PATCH] leds: pca9532: fix device_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 29 Dec 2016 22:34:47 +0100
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Julia Lawall <julia.lawall@...6.fr>,
        Joachim Eastwood <manabian@...il.com>
Cc:     Riku Voipio <riku.voipio@....fi>,
        Richard Purdie <rpurdie@...ys.net>,
        Pavel Machek <pavel@....cz>, linux-leds@...r.kernel.org,
        linux-kernel@...r.kernel.org, kbuild-all@...org
Subject: Re: [PATCH] leds: pca9532: fix device_node_continue.cocci warnings

Hi Julia,

This patch doesn't apply to current for-next branch
of linux-leds.git.

Best regards,
Jacek Anaszewski

On 12/29/2016 10:10 PM, Julia Lawall wrote:
> Device node iterators put the previous value of the index variable, so an
> explicit put causes a double put.
> 
> Generated by: scripts/coccinelle/iterators/device_node_continue.cocci
> 
> Signed-off-by: Julia Lawall <julia.lawall@...6.fr>
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> ---
> 
> I haven't looked at the context in detail, but given the rule, I assume
> that there is an iterator, such as for_each_child_of_node, and these
> iterators do a put on each iteration, so none is needed in the loop body.
> 
> tree:   https://github.com/manabian/linux-lpc lpc18xx_43xx_devel
> head:   9ee5f58bbb16c08da223c4b4933457e0eb72268d
> commit: c58957273142be779f62c17fae389ce9c134139f [44/55] leds: pca9532: use
> 
>  leds-pca9532.c |    3 ---
>  1 file changed, 3 deletions(-)
> 
> --- a/drivers/leds/leds-pca9532.c
> +++ b/drivers/leds/leds-pca9532.c
> @@ -473,7 +473,6 @@ pca9532_of_populate_pdata(struct device
> 
>  		res = of_property_read_u32(child, "reg", &reg);
>  		if ((res != 0) || (reg >= maxleds)) {
> -			of_node_put(child);
>  			continue;
>  		}
> 
> @@ -484,8 +483,6 @@ pca9532_of_populate_pdata(struct device
>  		of_property_read_u32(child, "type", &pdata->leds[reg].type);
>  		of_property_read_string(child, "linux,default-trigger",
>  					&pdata->leds[reg].default_trigger);
> -
> -		of_node_put(child);
>  	}
> 
>  	return pdata;
>