linux-kernel - Re: [PATCH 1/1] usb: xhci: clear EINT bit in status correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201612301322.uzSZqFSy%fengguang.wu@intel.com>
Date:   Fri, 30 Dec 2016 13:52:01 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Lu Baolu <baolu.lu@...ux.intel.com>
Cc:     kbuild-all@...org, Mathias Nyman <mathias.nyman@...ux.intel.com>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Lu Baolu <baolu.lu@...ux.intel.com>, stable@...r.kernel.org,
        Felipe Balbi <felipe.balbi@...ux.intel.com>
Subject: Re: [PATCH 1/1] usb: xhci: clear EINT bit in status correctly

Hi Lu,

[auto build test WARNING on usb/usb-testing]
[also build test WARNING on v4.10-rc1 next-20161224]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Lu-Baolu/usb-xhci-clear-EINT-bit-in-status-correctly/20161230-133444
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: i386-randconfig-x003-201652 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers/usb/host/xhci.c: In function 'xhci_stop':
>> drivers/usb/host/xhci.c:724:14: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]
     writel(temp & ~0x1fff | STS_EINT, &xhci->op_regs->status);
            ~~~~~^~~~~~~~~
   drivers/usb/host/xhci.c: In function 'xhci_resume':
   drivers/usb/host/xhci.c:1057:15: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]
      writel(temp & ~0x1fff | STS_EINT, &xhci->op_regs->status);
             ~~~~~^~~~~~~~~

vim +724 drivers/usb/host/xhci.c

   708	
   709		/* Deleting Compliance Mode Recovery Timer */
   710		if ((xhci->quirks & XHCI_COMP_MODE_QUIRK) &&
   711				(!(xhci_all_ports_seen_u0(xhci)))) {
   712			del_timer_sync(&xhci->comp_mode_recovery_timer);
   713			xhci_dbg_trace(xhci, trace_xhci_dbg_quirks,
   714					"%s: compliance mode recovery timer deleted",
   715					__func__);
   716		}
   717	
   718		if (xhci->quirks & XHCI_AMD_PLL_FIX)
   719			usb_amd_dev_put();
   720	
   721		xhci_dbg_trace(xhci, trace_xhci_dbg_init,
   722				"// Disabling event ring interrupts");
   723		temp = readl(&xhci->op_regs->status);
 > 724		writel(temp & ~0x1fff | STS_EINT, &xhci->op_regs->status);
   725		temp = readl(&xhci->ir_set->irq_pending);
   726		writel(ER_IRQ_DISABLE(temp), &xhci->ir_set->irq_pending);
   727		xhci_print_ir_set(xhci, 0);
   728	
   729		xhci_dbg_trace(xhci, trace_xhci_dbg_init, "cleaning up memory");
   730		xhci_mem_cleanup(xhci);
   731		xhci_dbg_trace(xhci, trace_xhci_dbg_init,
   732				"xhci_stop completed - status = %x",

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (28186 bytes)