lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <201612301415.Kdr9XbfS%fengguang.wu@intel.com>
Date:   Fri, 30 Dec 2016 14:19:28 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Lu Baolu <baolu.lu@...ux.intel.com>
Cc:     kbuild-all@...org, Mathias Nyman <mathias.nyman@...ux.intel.com>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Lu Baolu <baolu.lu@...ux.intel.com>, stable@...r.kernel.org,
        Felipe Balbi <felipe.balbi@...ux.intel.com>
Subject: Re: [PATCH 1/1] usb: xhci: clear EINT bit in status correctly

Hi Lu,

[auto build test WARNING on usb/usb-testing]
[also build test WARNING on v4.10-rc1 next-20161224]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Lu-Baolu/usb-xhci-clear-EINT-bit-in-status-correctly/20161230-133444
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 4.9.0
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=m68k 

All warnings (new ones prefixed by >>):

   In file included from include/linux/swab.h:4:0,
                    from include/uapi/linux/byteorder/big_endian.h:12,
                    from include/linux/byteorder/big_endian.h:4,
                    from arch/m68k/include/uapi/asm/byteorder.h:4,
                    from include/asm-generic/bitops/le.h:5,
                    from arch/m68k/include/asm/bitops.h:518,
                    from include/linux/bitops.h:36,
                    from include/linux/kernel.h:10,
                    from include/linux/list.h:8,
                    from include/linux/pci.h:25,
                    from drivers/usb/host/xhci.c:23:
   drivers/usb/host/xhci.c: In function 'xhci_stop':
   drivers/usb/host/xhci.c:724:14: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]
     writel(temp & ~0x1fff | STS_EINT, &xhci->op_regs->status);
                 ^
   include/uapi/linux/swab.h:116:32: note: in definition of macro '__swab32'
     (__builtin_constant_p((__u32)(x)) ? \
                                   ^
   include/linux/byteorder/generic.h:87:21: note: in expansion of macro '__cpu_to_le32'
    #define cpu_to_le32 __cpu_to_le32
                        ^
>> arch/m68k/include/asm/io_mm.h:452:26: note: in expansion of macro 'out_le32'
    #define writel(val,addr) out_le32((addr),(val))
                             ^
   drivers/usb/host/xhci.c:724:2: note: in expansion of macro 'writel'
     writel(temp & ~0x1fff | STS_EINT, &xhci->op_regs->status);
     ^
   drivers/usb/host/xhci.c:724:14: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]
     writel(temp & ~0x1fff | STS_EINT, &xhci->op_regs->status);
                 ^
   include/uapi/linux/swab.h:17:12: note: in definition of macro '___constant_swab32'
     (((__u32)(x) & (__u32)0x000000ffUL) << 24) |  \
               ^
   include/uapi/linux/byteorder/big_endian.h:32:43: note: in expansion of macro '__swab32'
    #define __cpu_to_le32(x) ((__force __le32)__swab32((x)))
                                              ^
   include/linux/byteorder/generic.h:87:21: note: in expansion of macro '__cpu_to_le32'
    #define cpu_to_le32 __cpu_to_le32
                        ^
>> arch/m68k/include/asm/io_mm.h:452:26: note: in expansion of macro 'out_le32'
    #define writel(val,addr) out_le32((addr),(val))
                             ^
   drivers/usb/host/xhci.c:724:2: note: in expansion of macro 'writel'
     writel(temp & ~0x1fff | STS_EINT, &xhci->op_regs->status);
     ^
   drivers/usb/host/xhci.c:724:14: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]
     writel(temp & ~0x1fff | STS_EINT, &xhci->op_regs->status);
                 ^
   include/uapi/linux/swab.h:18:12: note: in definition of macro '___constant_swab32'
     (((__u32)(x) & (__u32)0x0000ff00UL) <<  8) |  \
               ^
   include/uapi/linux/byteorder/big_endian.h:32:43: note: in expansion of macro '__swab32'
    #define __cpu_to_le32(x) ((__force __le32)__swab32((x)))
                                              ^
   include/linux/byteorder/generic.h:87:21: note: in expansion of macro '__cpu_to_le32'
    #define cpu_to_le32 __cpu_to_le32
                        ^
>> arch/m68k/include/asm/io_mm.h:452:26: note: in expansion of macro 'out_le32'
    #define writel(val,addr) out_le32((addr),(val))
                             ^
   drivers/usb/host/xhci.c:724:2: note: in expansion of macro 'writel'
     writel(temp & ~0x1fff | STS_EINT, &xhci->op_regs->status);
     ^
   drivers/usb/host/xhci.c:724:14: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]
     writel(temp & ~0x1fff | STS_EINT, &xhci->op_regs->status);
                 ^
   include/uapi/linux/swab.h:19:12: note: in definition of macro '___constant_swab32'
     (((__u32)(x) & (__u32)0x00ff0000UL) >>  8) |  \
               ^
   include/uapi/linux/byteorder/big_endian.h:32:43: note: in expansion of macro '__swab32'
    #define __cpu_to_le32(x) ((__force __le32)__swab32((x)))
                                              ^
   include/linux/byteorder/generic.h:87:21: note: in expansion of macro '__cpu_to_le32'
    #define cpu_to_le32 __cpu_to_le32
                        ^
>> arch/m68k/include/asm/io_mm.h:452:26: note: in expansion of macro 'out_le32'
    #define writel(val,addr) out_le32((addr),(val))
                             ^
   drivers/usb/host/xhci.c:724:2: note: in expansion of macro 'writel'
     writel(temp & ~0x1fff | STS_EINT, &xhci->op_regs->status);
     ^
   drivers/usb/host/xhci.c:724:14: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]
     writel(temp & ~0x1fff | STS_EINT, &xhci->op_regs->status);
                 ^
   include/uapi/linux/swab.h:20:12: note: in definition of macro '___constant_swab32'
     (((__u32)(x) & (__u32)0xff000000UL) >> 24)))
               ^
   include/uapi/linux/byteorder/big_endian.h:32:43: note: in expansion of macro '__swab32'
    #define __cpu_to_le32(x) ((__force __le32)__swab32((x)))
                                              ^
   include/linux/byteorder/generic.h:87:21: note: in expansion of macro '__cpu_to_le32'
    #define cpu_to_le32 __cpu_to_le32
                        ^
>> arch/m68k/include/asm/io_mm.h:452:26: note: in expansion of macro 'out_le32'
    #define writel(val,addr) out_le32((addr),(val))
                             ^
   drivers/usb/host/xhci.c:724:2: note: in expansion of macro 'writel'
     writel(temp & ~0x1fff | STS_EINT, &xhci->op_regs->status);
     ^
   drivers/usb/host/xhci.c:724:14: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]
     writel(temp & ~0x1fff | STS_EINT, &xhci->op_regs->status);
                 ^
   include/uapi/linux/swab.h:118:12: note: in definition of macro '__swab32'
     __fswab32(x))
               ^
   include/linux/byteorder/generic.h:87:21: note: in expansion of macro '__cpu_to_le32'
    #define cpu_to_le32 __cpu_to_le32
                        ^
>> arch/m68k/include/asm/io_mm.h:452:26: note: in expansion of macro 'out_le32'
    #define writel(val,addr) out_le32((addr),(val))
                             ^
   drivers/usb/host/xhci.c:724:2: note: in expansion of macro 'writel'
     writel(temp & ~0x1fff | STS_EINT, &xhci->op_regs->status);
     ^

vim +/out_le32 +452 arch/m68k/include/asm/io_mm.h

f9569e1d include/asm-m68k/io.h         Al Viro            2007-07-20  436  #define insw(port,buf,nr)  ((void)0)
f9569e1d include/asm-m68k/io.h         Al Viro            2007-07-20  437  #define outsw(port,buf,nr) ((void)0)
f9569e1d include/asm-m68k/io.h         Al Viro            2007-07-20  438  #define insl(port,buf,nr)  ((void)0)
f9569e1d include/asm-m68k/io.h         Al Viro            2007-07-20  439  #define outsl(port,buf,nr) ((void)0)
^1da177e include/asm-m68k/io.h         Linus Torvalds     2005-04-16  440  
^1da177e include/asm-m68k/io.h         Linus Torvalds     2005-04-16  441  /*
^1da177e include/asm-m68k/io.h         Linus Torvalds     2005-04-16  442   * These should be valid on any ioremap()ed region
^1da177e include/asm-m68k/io.h         Linus Torvalds     2005-04-16  443   */
^1da177e include/asm-m68k/io.h         Linus Torvalds     2005-04-16  444  #define readb(addr)      in_8(addr)
^1da177e include/asm-m68k/io.h         Linus Torvalds     2005-04-16  445  #define writeb(val,addr) out_8((addr),(val))
f9569e1d include/asm-m68k/io.h         Al Viro            2007-07-20  446  #define readw(addr)      in_le16(addr)
f9569e1d include/asm-m68k/io.h         Al Viro            2007-07-20  447  #define writew(val,addr) out_le16((addr),(val))
2171a19a include/asm-m68k/io.h         Adrian Bunk        2008-10-13  448  
84b16b7b arch/m68k/include/asm/io_mm.h Michael Schmitz    2013-04-06  449  #endif /* !CONFIG_ISA && !CONFIG_ATARI_ROM_ISA */
2171a19a include/asm-m68k/io.h         Adrian Bunk        2008-10-13  450  
^1da177e include/asm-m68k/io.h         Linus Torvalds     2005-04-16  451  #define readl(addr)      in_le32(addr)
^1da177e include/asm-m68k/io.h         Linus Torvalds     2005-04-16 @452  #define writel(val,addr) out_le32((addr),(val))
^1da177e include/asm-m68k/io.h         Linus Torvalds     2005-04-16  453  
f5db9c6a arch/m68k/include/asm/io_mm.h Geert Uytterhoeven 2012-04-15  454  #define readsb(port, buf, nr)     raw_insb((port), (u8 *)(buf), (nr))
f5db9c6a arch/m68k/include/asm/io_mm.h Geert Uytterhoeven 2012-04-15  455  #define readsw(port, buf, nr)     raw_insw((port), (u16 *)(buf), (nr))
f5db9c6a arch/m68k/include/asm/io_mm.h Geert Uytterhoeven 2012-04-15  456  #define readsl(port, buf, nr)     raw_insl((port), (u32 *)(buf), (nr))
f5db9c6a arch/m68k/include/asm/io_mm.h Geert Uytterhoeven 2012-04-15  457  #define writesb(port, buf, nr)    raw_outsb((port), (u8 *)(buf), (nr))
f5db9c6a arch/m68k/include/asm/io_mm.h Geert Uytterhoeven 2012-04-15  458  #define writesw(port, buf, nr)    raw_outsw((port), (u16 *)(buf), (nr))
f5db9c6a arch/m68k/include/asm/io_mm.h Geert Uytterhoeven 2012-04-15  459  #define writesl(port, buf, nr)    raw_outsl((port), (u32 *)(buf), (nr))
f5db9c6a arch/m68k/include/asm/io_mm.h Geert Uytterhoeven 2012-04-15  460  

:::::: The code at line 452 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@...970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@...970.osdl.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (38889 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ